Skip to content

Commit

Permalink
Update pkg/cache/v3/resource.go
Browse files Browse the repository at this point in the history
Co-authored-by: Antoine Tollenaere <[email protected]>
Signed-off-by: Valerian Roche <[email protected]>
  • Loading branch information
valerian-roche and atollena authored Jan 16, 2024
1 parent 998c937 commit 24a2de3
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/cache/v3/resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,9 @@ func GetResourceName(res types.Resource) string {
func ResourceRequiresFullStateInSotw(typeURL resource.Type) bool {
// From https://www.envoyproxy.io/docs/envoy/v1.28.0/api-docs/xds_protocol#grouping-resources-into-responses,
// when using sotw the control-plane MUST return all requested resources (or simply all if wildcard)
// for some types. This is relied on by xds-grpc which is explicitly requesting clusters but expect
// to receive all existing resources
// for some types. This is relied on by xds-grpc which is explicitly requesting clusters and listeners
// but expects to receive all existing resources for those types. Missing clusters or listeners are
// considered deleted.
switch typeURL {
case resource.ClusterType:
return true
Expand Down

0 comments on commit 24a2de3

Please sign in to comment.