Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify libgeos and protobuf version we work with #1978

Closed
vmihaylenko opened this issue Oct 17, 2019 · 1 comment
Closed

Specify libgeos and protobuf version we work with #1978

vmihaylenko opened this issue Oct 17, 2019 · 1 comment

Comments

@vmihaylenko
Copy link
Contributor

Why

So I was building Valhalla and found out it can't be built with libgeos3.8 (which is libspatialite dependency). The maximum version we still support is libgeos3.7. For 3.8 (which is currently presented in brew) we have to modify out code otherwise it doesn't compile.
The same story with protobuf but I'm not sure the maximum version we still support. I can say that's 3.9 version (and 3.10 which is currently in brew) can't be compiled and also 3.6 version works just fine. So IMO it leads us to have a mason file in valhalla with specific libs we need to correct work. But so far we can specify that we work with libgeos3.7 and lower and also with protobuf3.6 (and probably lower versions but need to determine).

Unknowns

The minimum version of libgeos and min/max version of protobuf.

@kevinkreiser
Copy link
Member

we've fixed the protobuf part of this. but the geos issue remains. i wonder if some tricky use of auto/decltype can get us around this issue with minimal ifdefs.. had a hack on this this morning with @yuzheyan but didnt finish it up yet

purew added a commit that referenced this issue Dec 10, 2019
kevinkreiser pushed a commit that referenced this issue Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants