Stop impact, PH, turn channel speeds, and tagged speed updates #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do no increase stop impact if transitioning from ramp to non ramp and both edges are marked internal.
gknisely
changed the title
yuzheyan
added a commit
that referenced
this pull request
Feb 5, 2020
* master: Clarify cmake flag preconditions. Fix coverage flag. Include appropriate license header. Disable -Werror in CI build. Remove -Wconversion Update README and CI configuration. Revert coverage flags back to being PUBLIC. Remove stray comment. Refactored flags to use a function; fixed valhalla_module target; flag for Werror Adds a cmake module for libcxx flag macros. Stop impact, PH, turn channel speeds, and tagged speed updates (#2198) add isochrone snapped center coordinates to response (#2111) Summary Doesnt Match Accumulated Maneuvers (#2195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Tagged speeds were not properly marked. We were not using forward and backward speeds to flag if a speed is tagged or not.
Should not update turn channel speeds if we are not inferring them.
Added additional logic to handle PH in the conditional restrictions. Added more tests.
Do not update stop impact for ramps if they are marked as internal.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?