Fix signature to re-enable transition cost for motorcycle #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpat
previously approved these changes
Feb 4, 2021
gknisely
previously approved these changes
Feb 4, 2021
mandeepsandhu
previously approved these changes
Feb 4, 2021
| @@ -242,8 +241,7 @@ class MotorcycleCost : public DynamicCost { | |||
| virtual Cost TransitionCostReverse(const uint32_t idx, | |||
| const baldr::NodeInfo* node, | |||
| const baldr::DirectedEdge* pred, | |||
| const baldr::DirectedEdge* edge, | |||
| const bool has_traffic) const; | |||
| const baldr::DirectedEdge* edge) const override; | |||
There was a problem hiding this comment.
You can remove comment for has_traffic from both function's doc comments.
There was a problem hiding this comment.
Good catch! 👍
SvetlanaBayarovich
dismissed stale reviews from mandeepsandhu, gknisely, and danpat
via
ebbba37
gknisely
approved these changes
Feb 4, 2021
mandeepsandhu
approved these changes
Feb 4, 2021
kevinkreiser
reviewed
Feb 4, 2021
| @@ -10,6 +10,7 @@ | |||
| * FIXED: Mark the restriction start and end as via ways to fix IsBridgingEdge function in Bidirectional Astar [#2796](https://github.com/valhalla/valhalla/pull/2796) | |||
| * FIXED: Dont add predictive traffic to the tile if it's empty [#2826](https://github.com/valhalla/valhalla/pull/2826) | |||
| * FIXED: Fix logic bidirectional astar to avoid double u-turns and extra detours [#2802](https://github.com/valhalla/valhalla/pull/2802) | |||
| * FIXED: Re-enable transition cost for motorcycle profile [#2837](https://github.com/valhalla/valhalla/pull/2837) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Method signature got inconsistent with the one of the base class. As a result, zero transition cost was applied for motorcycle profile.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?