Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgotten review fixes #3381

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Forgotten review fixes #3381

merged 2 commits into from
Oct 29, 2021

Conversation

genadz
Copy link
Contributor

@genadz genadz commented Oct 29, 2021 •
edited
Loading

Issue

These are review fixes related to the merged PR #3379.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

kevinkreiser
kevinkreiser previously approved these changes Oct 29, 2021
View reviewed changes
@kevinkreiser
Copy link
Member

thanks for coming back and getting these, much appreciated!

@genadz
Copy link
Contributor Author

genadz commented Oct 29, 2021

thanks for coming back and getting these, much appreciated!

thank you very much for the review!!

@genadz genadz merged commit e445ac2 into master Oct 29, 2021
@purew purew deleted the kgv_openlr_bearing branch October 29, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkreiser kevinkreiser kevinkreiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genadz @kevinkreiser