update timezone database #4446
Merged
update timezone database #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
force-pushed
the
nn-timezone-update
branch
2 times, most recently
from
dbe14b9
to
e18463d
Compare
nilsnolde
force-pushed
the
nn-timezone-update
branch
from
e18463d
to
465c220
Compare
nilsnolde
commented
Dec 11, 2023
| @@ -1,433 +0,0 @@ | |||
| "ID","STD ABBR","STD NAME","DST ABBR","DST NAME","GMT offset","DST adjustment","DST Start Date rule","Start time","DST End date rule","End time" | |||
There was a problem hiding this comment.
seems like this was for boost::date_time which was long abandoned
gknisely
previously approved these changes
Dec 12, 2023
nilsnolde
commented
Dec 12, 2023
src/baldr/CMakeLists.txt
Outdated
| WORKING_DIRECTORY ${VALHALLA_SOURCE_DIR} | ||
| COMMENT "Compiling date_time/windowsZones.xml to date_time_windows_zones.h" | ||
| DEPENDS ${VALHALLA_SOURCE_DIR}/date_time/windowsZones.xml) | ||
|
|
||
| file(GLOB headers ${VALHALLA_SOURCE_DIR}/valhalla/baldr/*.h) |
There was a problem hiding this comment.
huch, this was definitely not intended..
There was a problem hiding this comment.
sorry @gknisely that dismissed your review
gknisely
previously approved these changes
Dec 12, 2023
scripts/valhalla_build_timezones
Outdated
|
|
||
| echo "downloading timezone polygon file." 1>&2 | ||
| curl -L -s -o ./timezones-with-oceans.shapefile.zip ${url} || error_exit "curl failed for ${url}" | ||
| unzip ./timezones-with-oceans.shapefile.zip 1>&2 || error_exit "unzip failed" | ||
|
|
||
| tz_file=$(mktemp) | ||
| spatialite_tool -i -shp ./dist/combined-shapefile-with-oceans -d ${tz_file} -t tz_world -s 4326 -g geom -c UTF-8 1>&2 || error_exit "spatialite_tool import failed" | ||
| spatialite_tool -i -shp "./combined-shapefile-with-oceans" -d "${tz_file}" -t tz_world -s 4326 -g geom -c UTF-8 |
There was a problem hiding this comment.
why remove the error checking, surely its still possible something goes wrong
There was a problem hiding this comment.
uh, just a fail, will add again
src/mjolnir/admin.cc
Outdated
| @@ -24,6 +24,7 @@ sqlite3* GetDBHandle(const std::string& database) { | |||
| sqlite3_close(db_handle); | |||
| return nullptr; | |||
| } | |||
| // sqlite3_extended_result_codes(db_handle, 1); | |||
There was a problem hiding this comment.
hm, let me uncomment. it will give better error codes/msgs
kevinkreiser
previously approved these changes
Dec 13, 2023
nilsnolde
dismissed stale reviews from kevinkreiser and gknisely
via
35a0069
|
fixed the small comments: 35a0069 |
gknisely
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3817
date_timefolder (except windowsZones.xml) and submodules the tz repo, which needed a bit of CMake stuff to make it work; now we know the version of the IANA data as wellAlso we could use the OS timezone DBs now. I left the windowsZones.xml in here as well.
Other than that, the code itself is pretty well documented.