Feature Request: National identity number

[dghaehre]

Norway uses a national identity number: https://www.skatteetaten.no/en/person/foreign/norwegian-identification-number/national-identity-number/

I would assume this is something other countries has as well. I also assume this is not the same as Identity Card?

If this is something that is interesting I would love to create a PR :)

[profnandaa]

Sounds good to me, suggesting to add it on isIdentityCard? PR welcome! 🎉

[dghaehre]

As a norwegian, isIdentityNumber sounds better than isIdentityCard. But isIdentityCard works as well, I could just add a comment in the readme.

What do you think, should I add it to isIdentityCard or create isIdentityNumber?

[profnandaa]

For sure, _number sounds better :) Perhaps we make an alias for that too for legacy support. However, implement with the _card source.

…

-na

On Sat, Aug 31, 2019 at 11:03 AM Daniel Haehre ***@***.***> wrote: As a norwegian, isIdentityNumber sounds better than isIdentityCard. But isIdentityCard works as well, I could just add a comment in the readme. What do you think, should I add it to isIdentityCard or create isIdentityNumber? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1097?email_source=notifications&email_token=AAB7ZEOZ4QRD6PY5EPRPUZ3QHIQUTA5CNFSM4ISS34GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TH2HA#issuecomment-526810396>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB7ZEJH7ODJAE6EZ7NIKVTQHIQUTANCNFSM4ISS34GA> .

-- *___Nandaa **Anthony* *,*Software Craftsman & Mentor *Twitter/Github: *@profnandaa <https://twitter.com/profnandaa>

[dghaehre]

Great, sounds good :)

[lorenzodb1]

I just saw this issue and its related pull request. If this goes through, I'd like to work on adding Italy's codice fiscale and Canada's SIN number to it, if you let me.

[profnandaa]

@lorenzodb1 -- for sure, please do. Thanks! 👍

[lorenzodb1]

@profnandaa awesome, thanks! I'll wait for @dghaehre changes to go through then

[dghaehre]

closing because of #1324