Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union Pay credit cards are always invalid #535

Closed
dhAlcojor opened this issue May 31, 2016 · 0 comments · Fixed by #539
Closed

Union Pay credit cards are always invalid #535

dhAlcojor opened this issue May 31, 2016 · 0 comments · Fixed by #539

Comments

@dhAlcojor
Copy link
Contributor

These Union Pay credit card numbers should be valid, but the isCreditCard() function always return false (for these):
6283875070985593
6263892624162870
6234917882863855
6234698580215388
6226050967750613
6246281879460688
@dhAlcojor dhAlcojor mentioned this issue Jun 1, 2016
Closed
dhAlcojor added a commit to dhAlcojor/validator.js that referenced this issue Jun 4, 2016
@dhAlcojor
Fix issue validatorjs#535: add validation for Union Pay credit cards
d9895f7
@dhAlcojor dhAlcojor mentioned this issue Jun 9, 2016
Merged
chriso added a commit that referenced this issue Jun 9, 2016
@chriso
Merge pull request #539 from dhAlcojor/master
9bfb273 
Fix issue #535 and add test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dhAlcojor