You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For my #890 PR, I intentionally left out isFloat since I noticed that it does not throw an error for "unsupported" locales but rather falls back on a default.
Should we add throwing an error now since that has been the pattern for the rest, or will we be risking backward incompatibility (before line 7)?
// check for unsupported locale// for uniformity with other locale-based functionsif(options.locale&&!decimal[options.locale]){thrownewError(`Invalid locale '${options.locale}'`);}
OR
Should we just export the locales alone isFloatLocales and leave everything as is?
The text was updated successfully, but these errors were encountered:
For my #890 PR, I intentionally left out
isFloat
since I noticed that it does not throw an error for "unsupported" locales but rather falls back on a default.https://github.com/chriso/validator.js/blob/master/src/lib/isFloat.js#L7
Should we add throwing an error now since that has been the pattern for the rest, or will we be risking backward incompatibility (before line 7)?
OR
Should we just export the locales alone
isFloatLocales
and leave everything as is?The text was updated successfully, but these errors were encountered: