Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): add support for ar-EG 015 #1010

Merged
merged 4 commits into from
Apr 11, 2019

Conversation

AMRALAA10
Copy link
Contributor

add support for Eg phone numbers that starts with 015

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add few tests for this and should be ready for merge.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Apr 10, 2019
@AMRALAA10
Copy link
Contributor Author

@profnandaa done 👍

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@profnandaa profnandaa changed the title add support for eg 015 phones feat(isMobilePhone): add support for ar-EG 015 Apr 11, 2019
@profnandaa profnandaa merged commit 2c68a31 into validatorjs:master Apr 11, 2019
chriso added a commit that referenced this pull request May 23, 2019
Some PRs (e.g. #1010 and #1017) haven't been compiled
properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants