Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up PR 982 #1062

Merged
merged 4 commits into from
Jul 24, 2019
Merged

Clean up PR 982 #1062

merged 4 commits into from
Jul 24, 2019

Conversation

ezkemboi
Copy link
Member

No description provided.

@ezkemboi
Copy link
Member Author

@profnandaa you can take a look #982.
The PR was good but lacked testing.
I have fixed it in this PR.

Cc. @itaychi.

profnandaa
profnandaa approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa profnandaa merged commit cf00ee6 into validatorjs:master Jul 24, 2019
@profnandaa profnandaa mentioned this pull request Jul 28, 2019
Closed
@davidmsvetlecic
Copy link

Just curious, why A) vs B)?:
A) var hash = new RegExp("^[a-fA-F0-9]{".concat(lengths[algorithm], "}$"));
B) var hash = new RegExp("^[A-F0-9]{".concat(lengths[algorithm], "}$"), "i");

@Kiliandeca Kiliandeca mentioned this pull request Oct 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ezkemboi @davidmsvetlecic @profnandaa @itaychi