feat(isLocale): validate isLocale #1072

ezkemboi · 2019-07-28T12:31:25Z

It validates different languages for different geographical location
Closes isLocale #954

profnandaa · 2019-08-02T12:00:38Z

I'll need some more time to look into this. There's also a general ISO guideline for locales, perhaps we should also consider that.

QQ, what was your source for this locales, can include the ref link on the PR?

ezkemboi · 2019-08-02T12:54:26Z

Here is what I used @profnandaa https://gist.github.com/jacobbubu/1836273

But, looking at this, https://gist.github.com/jasef/337431c43c3addb2cbd5eb215b376179, https://gist.github.com/jacobbubu/1836273 and https://github.com/umpirsky/locale-list/tree/master/data, there seem to be more locales available.

But, I am fetching those locale data are the ones provided by Apple devices.

profnandaa · 2019-08-17T12:33:35Z

src/lib/isLocale.js

+
+/* eslint-disable max-len */
+const locales = {
+  af_NA: 'Afrikaans (Namibia)',


Possible to come up with a general regex for this, since we're bound to have more locales coming up. I see for instance en_KE is left out.

Alright, no problem. I can come up with it, though it might not be a guarantee that we will get them. (In case I find a unique way of identifying a locale, sure, will do the regex).

Alternatively, let me try find as many possible locales as possible for the same. And add them. I will try use some more resources such as this

@profnandaa, I think after reading this StackOverflow discussion,
I will go ahead to make use of regex. Thanks for your thoughts.

What locale could consists of: 1. Language code: ISO 639 2 or 3, or 4 for future use, alpha. 2. Optional script code: ISO 15924 4 alpha or 3 digit. 3. Optional country code: ISO 3166-1 2 alpha or 3 digit. 4. Separated by underscores or dashes. Valid examples are: - de - en-US - zh-Hant-TW - En-au - aZ_cYrl-aZ.

You can add label needs update on this one.

ezkemboi · 2019-08-18T12:52:34Z

@profnandaa, I have updated the PR to make use of regex instead of listing all possible locales, which keep on increasing and at the same time they are too many.

ezkemboi · 2019-08-18T13:03:38Z

Here is a link to different locales :
https://github.com/go-playground/locales

There are these two complex locales that I am trying to fix them on it also,
'en_US_POSIX',
'ca_ES_VALENCIA',

ezkemboi · 2019-08-18T21:13:07Z

Since the regex validates all other locales except the two mentioned above, I have added this code

if (str === 'en_US_POSIX' || str === 'ca_ES_VALENCIA') {
    return true;
}

If I add regex to validate en_US_POSIX and ca_ES_VALENCIA, then it means that it might validate locales that do not exist or does not match the pattern.
E.g it can validate en_US_POSIXXX if let's say I check on character length of the last part.

So, this made me go with the option of adding if statement for the two.

rubiin · 2019-10-15T08:55:21Z

@profnandaa @ezkemboi I think we can use this to check language too

profnandaa · 2019-10-16T19:54:27Z

src/lib/isLocale.js

+
+export default function isLocale(str) {
+  assertString(str);
+  if (str === 'en_US_POSIX' || str === 'ca_ES_VALENCIA') {


Are these 2 the only exceptions? 🤔

Yes, they are exceptions.

ezkemboi · 2019-10-16T20:04:22Z

@rubiin, thanks for the feedback, I will do a check on that possibility (Though, I thought languages are more than what are in locales).
@profnandaa can help give point of view.

ezkemboi · 2019-10-16T20:06:54Z

@profnandaa, I think @vlapo is in need of this feature?
But, from a library that makes use of validator.js
Here is a link
typestack/class-validator#425

profnandaa · 2019-10-17T04:41:09Z

Sorry for the delay. Will check and land today, Though the release will take some time. ./na

On Wed, Oct 16, 2019 at 11:06 PM Ezrqn Kemboi ***@***.***> wrote: @profnandaa <https://github.com/profnandaa>, I think @vlapo <https://github.com/vlapo> is in need of this feature? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1072?email_source=notifications&email_token=AAB7ZEINMIYGZVBQ35D3S6TQO5X6HA5CNFSM4IHMMFA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNYSBI#issuecomment-542869765>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB7ZEML3Z7RSXH4PDAK3STQO5X6HANCNFSM4IHMMFAQ> .

-- Sent from a tiny device while on the move.

ezkemboi · 2019-10-17T06:34:30Z

No problem @profnandaa.
cc. @vlapo.

johannesschobel · 2019-11-20T11:28:51Z

what is the current status of this PR? thanks a lot!

ezkemboi · 2019-11-20T11:53:46Z

@profnandaa can inform us if it is ready.
On my end it is good.

johannesschobel · 2019-12-04T09:13:47Z

ping again .. i would really need this feature in class-validator..

ezkemboi · 2019-12-04T09:33:28Z

@profnandaa and @chriso.
Will you be able to have time to check on this one, please?

rubiin · 2019-12-04T09:38:53Z

@profnandaa and @chriso.
Will you be able to have time to check on this one, please?

This is a most awaited feature as some other things like language validation also kind of depends on this

profnandaa · 2019-12-06T09:40:24Z

Sorry for my delay on this one, on it! 👍

profnandaa

I'll make use of any extra pair of eyes. LGTM though, now just fix the merge conflicts.

ezkemboi · 2019-12-06T10:31:09Z

@profnandaa, I have fixed the merge conflicts. Though there are some unnecessary changes here.
I will have a look at it. I think I did a merge, which has taken such a direction.

@rubiin, @johannesschobel can you have an extra eye on this one.
Thanks in advance.

rubiin · 2019-12-06T13:19:49Z

@profnandaa, I have fixed the merge conflicts. Though there are some unnecessary changes here.
I will have a look at it. I think I did a merge, which has taken such a direction.

@rubiin, @johannesschobel can you have an extra eye on this one.
Thanks in advance.

sure

rubiin · 2019-12-06T13:59:36Z

looks good so far

johannesschobel · 2019-12-18T11:14:26Z

when can this be merged? 😟

arkus7 · 2020-01-24T12:52:02Z

Any update on this? 🙏

ezkemboi · 2020-01-24T17:23:06Z

@profnandaa, I see that many people are demanding this feature.
Is there anything we can do to accelerate it's landing?

profnandaa · 2020-01-26T19:40:48Z

@ezkemboi -- please fix the merge conflicts and I should land it.

profnandaa · 2020-01-26T19:41:40Z

Remember to remove the unrelated changes, I don't think we should have a 17-files diff.

ezkemboi · 2020-01-27T07:34:12Z

I will do that.

ezkemboi · 2020-01-28T15:02:20Z

@profnandaa, I have fixed the issues raised.
You can take a look at it.

profnandaa · 2020-02-14T18:52:48Z

1000 apologies for forgetting this PR.

profnandaa · 2020-02-14T18:54:13Z

@ezkemboi -- just this m/c, I'll get a notification when you push. I'll merge it as soon.

ezkemboi · 2020-02-14T18:54:52Z

@profnandaa on it. Let me finish some sort of issue here coz, it seemed I had earlier merged the changes rather than rebasing them.

- it validates different languages for different geographical location - Closes validatorjs#954

johannesschobel · 2020-02-15T10:51:24Z

Woooooooha.. Thanks a lot

rubiin · 2020-02-15T15:04:26Z

Hope it gets published on next release

johannesschobel · 2020-02-19T10:24:19Z

Dear @profnandaa ,
can you please tag this commit as a new version?! it has been merged, but not released!

thanks a lot

profnandaa · 2020-02-19T19:02:01Z

@johannesschobel -- sure, our Feb release should be going out soon.
/cc. @chriso

ezkemboi force-pushed the islocale branch from ce18fae to 960cd63 Compare July 28, 2019 12:46

profnandaa added the 🕑 to-be-reviewed label Aug 2, 2019

profnandaa reviewed Aug 17, 2019

View reviewed changes

profnandaa removed the 🕑 to-be-reviewed label Aug 17, 2019

ezkemboi force-pushed the islocale branch 2 times, most recently from 221e743 to f41ac00 Compare August 18, 2019 12:49

profnandaa added the 🕑 to-be-reviewed label Aug 18, 2019

ezkemboi force-pushed the islocale branch from f41ac00 to 45f2b88 Compare August 18, 2019 21:08

ezkemboi force-pushed the islocale branch from 45f2b88 to 4f47c89 Compare September 7, 2019 12:06

vlapo mentioned this pull request Oct 14, 2019

feat: new isLocale validator typestack/class-validator#425

Closed

profnandaa reviewed Oct 16, 2019

View reviewed changes

profnandaa reviewed Dec 6, 2019

View reviewed changes

profnandaa added needs-more-review 🧹 needs-update For PRs that need to be updated before landing labels Dec 6, 2019

profnandaa removed the 🕑 to-be-reviewed label Dec 6, 2019

ezkemboi force-pushed the islocale branch from 051875d to 860fabf Compare January 28, 2020 15:00

profnandaa added ready-to-land For PRs that are reviewed and ready to be landed and removed needs-more-review labels Feb 14, 2020

feat(isLocale): validate isLocale

ca06b5d

- it validates different languages for different geographical location - Closes validatorjs#954

ezkemboi force-pushed the islocale branch from 860fabf to ca06b5d Compare February 14, 2020 19:24

profnandaa approved these changes Feb 15, 2020

View reviewed changes

profnandaa merged commit 7bd816e into validatorjs:master Feb 15, 2020

WikiRik mentioned this pull request Nov 7, 2022

isLocale does invalidate a lot of valid language tags #2100

Open

feat(isLocale): validate isLocale #1072

feat(isLocale): validate isLocale #1072

Conversation

ezkemboi commented Jul 28, 2019

profnandaa commented Aug 2, 2019

ezkemboi commented Aug 2, 2019

profnandaa Aug 17, 2019

Choose a reason for hiding this comment

ezkemboi Aug 17, 2019

Choose a reason for hiding this comment

ezkemboi Aug 17, 2019

Choose a reason for hiding this comment

ezkemboi commented Aug 18, 2019

ezkemboi commented Aug 18, 2019

ezkemboi commented Aug 18, 2019

rubiin commented Oct 15, 2019

profnandaa Oct 16, 2019

Choose a reason for hiding this comment

ezkemboi Oct 16, 2019

Choose a reason for hiding this comment

ezkemboi commented Oct 16, 2019

ezkemboi commented Oct 16, 2019 • edited Loading

profnandaa commented Oct 17, 2019 via email

ezkemboi commented Oct 17, 2019

johannesschobel commented Nov 20, 2019

ezkemboi commented Nov 20, 2019

johannesschobel commented Dec 4, 2019

ezkemboi commented Dec 4, 2019

rubiin commented Dec 4, 2019

profnandaa commented Dec 6, 2019

profnandaa left a comment

Choose a reason for hiding this comment

ezkemboi commented Dec 6, 2019 • edited Loading

rubiin commented Dec 6, 2019

rubiin commented Dec 6, 2019

johannesschobel commented Dec 18, 2019

arkus7 commented Jan 24, 2020

ezkemboi commented Jan 24, 2020

profnandaa commented Jan 26, 2020

profnandaa commented Jan 26, 2020

ezkemboi commented Jan 27, 2020

ezkemboi commented Jan 28, 2020

profnandaa commented Feb 14, 2020

profnandaa commented Feb 14, 2020

ezkemboi commented Feb 14, 2020 • edited Loading

johannesschobel commented Feb 15, 2020

rubiin commented Feb 15, 2020

johannesschobel commented Feb 19, 2020

profnandaa commented Feb 19, 2020

ezkemboi commented Oct 16, 2019 •

edited

Loading

ezkemboi commented Dec 6, 2019 •

edited

Loading

ezkemboi commented Feb 14, 2020 •

edited

Loading