Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build status travis on README #1124

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Update build status travis on README #1124

merged 1 commit into from
Oct 5, 2019

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Oct 3, 2019

No description provided.

@ezkemboi
Copy link
Member

ezkemboi commented Oct 4, 2019

Also, I was thinking that we could also have coverage status?

cc @profnandaa and @Tony133.

@Tony133
Copy link
Contributor Author

Tony133 commented Oct 5, 2019

Because no, it would be useful

cc @ezkemboi and @profnandaa

profnandaa
profnandaa approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! 🎉

@profnandaa
Copy link
Member

@ezkemboi - Ez, that sounds good to me, please raise a PR for that...

@profnandaa profnandaa merged commit cff8a58 into validatorjs:master Oct 5, 2019
@ezkemboi ezkemboi mentioned this pull request Oct 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezkemboi ezkemboi ezkemboi approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tony133 @ezkemboi @profnandaa