-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isEAN): implement isEAN validator #1244
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
"use strict"; | ||
|
||
Object.defineProperty(exports, "__esModule", { | ||
value: true | ||
}); | ||
exports.default = isEAN; | ||
|
||
var _assertString = _interopRequireDefault(require("./util/assertString")); | ||
|
||
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; } | ||
|
||
/** | ||
* The most commonly used EAN standard is | ||
* the thirteen-digit EAN-13, while the | ||
* less commonly used 8-digit EAN-8 barcode was | ||
* introduced for use on small packages. | ||
* EAN consists of: | ||
* GS1 prefix, manufacturer code, product code and check digit | ||
* Reference: https://en.wikipedia.org/wiki/International_Article_Number | ||
*/ | ||
|
||
/** | ||
* Define EAN Lenghts; 8 for EAN-8; 13 for EAN-13 | ||
* and Regular Expression for valid EANs (EAN-8, EAN-13), | ||
* with exact numberic matching of 8 or 13 digits [0-9] | ||
*/ | ||
var LENGTH_EAN_8 = 8; | ||
var validEanRegex = /(?<!\d)(\d{8}|\d{13})(?!\d)$/; | ||
/** | ||
* Get position weight given: | ||
* EAN length and digit index/position | ||
* | ||
* @param {number} length | ||
* @param {number} index | ||
* @return {number} | ||
*/ | ||
|
||
function getPositionWeightThroughLengthAndIndex(length, index) { | ||
if (length === LENGTH_EAN_8) { | ||
return index % 2 === 0 ? 3 : 1; | ||
} | ||
|
||
return index % 2 === 0 ? 1 : 3; | ||
} | ||
/** | ||
* Calculate EAN Check Digit | ||
* Reference: https://en.wikipedia.org/wiki/International_Article_Number#Calculation_of_checksum_digit | ||
* | ||
* @param {string} ean | ||
* @return {number} | ||
*/ | ||
|
||
|
||
function calculateCheckDigit(ean) { | ||
var checksum = ean.slice(0, -1).split('').map(function (char, index) { | ||
return Number(char) * getPositionWeightThroughLengthAndIndex(ean.length, index); | ||
}).reduce(function (acc, partialSum) { | ||
return acc + partialSum; | ||
}, 0); | ||
var remainder = 10 - checksum % 10; | ||
return remainder < 10 ? remainder : 0; | ||
} | ||
/** | ||
* Check if string is valid EAN: | ||
* Matches EAN-8/EAN-13 regex | ||
* Has valid check digit. | ||
* | ||
* @param {string} str | ||
* @return {boolean} | ||
*/ | ||
|
||
|
||
function isEAN(str) { | ||
(0, _assertString.default)(str); | ||
var actualCheckDigit = Number(str.slice(-1)); | ||
return validEanRegex.test(str) && actualCheckDigit === calculateCheckDigit(str); | ||
} | ||
|
||
module.exports = exports.default; | ||
module.exports.default = exports.default; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/** | ||
* The most commonly used EAN standard is | ||
* the thirteen-digit EAN-13, while the | ||
* less commonly used 8-digit EAN-8 barcode was | ||
* introduced for use on small packages. | ||
* EAN consists of: | ||
* GS1 prefix, manufacturer code, product code and check digit | ||
* Reference: https://en.wikipedia.org/wiki/International_Article_Number | ||
*/ | ||
|
||
import assertString from './util/assertString'; | ||
|
||
/** | ||
* Define EAN Lenghts; 8 for EAN-8; 13 for EAN-13 | ||
* and Regular Expression for valid EANs (EAN-8, EAN-13), | ||
* with exact numberic matching of 8 or 13 digits [0-9] | ||
*/ | ||
const LENGTH_EAN_8 = 8; | ||
const validEanRegex = /(?<!\d)(\d{8}|\d{13})(?!\d)$/; | ||
|
||
|
||
/** | ||
* Get position weight given: | ||
* EAN length and digit index/position | ||
* | ||
* @param {number} length | ||
* @param {number} index | ||
* @return {number} | ||
*/ | ||
function getPositionWeightThroughLengthAndIndex(length, index) { | ||
if (length === LENGTH_EAN_8) { | ||
return (index % 2 === 0) ? 3 : 1; | ||
} | ||
|
||
return (index % 2 === 0) ? 1 : 3; | ||
} | ||
|
||
/** | ||
* Calculate EAN Check Digit | ||
* Reference: https://en.wikipedia.org/wiki/International_Article_Number#Calculation_of_checksum_digit | ||
* | ||
* @param {string} ean | ||
* @return {number} | ||
*/ | ||
function calculateCheckDigit(ean) { | ||
const checksum = ean | ||
.slice(0, -1) | ||
.split('') | ||
.map((char, index) => Number(char) * getPositionWeightThroughLengthAndIndex(ean.length, index)) | ||
.reduce((acc, partialSum) => acc + partialSum, 0); | ||
|
||
const remainder = 10 - (checksum % 10); | ||
|
||
return remainder < 10 ? remainder : 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The case where remainder equals 10 is uncovered in mocha tests. Can you add a test case? |
||
} | ||
|
||
/** | ||
* Check if string is valid EAN: | ||
* Matches EAN-8/EAN-13 regex | ||
* Has valid check digit. | ||
* | ||
* @param {string} str | ||
* @return {boolean} | ||
*/ | ||
export default function isEAN(str) { | ||
assertString(str); | ||
const actualCheckDigit = Number(str.slice(-1)); | ||
|
||
return validEanRegex.test(str) && actualCheckDigit === calculateCheckDigit(str); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RegExp lookbehind assertions are an ES2018 feature. They are not supported in all platforms.
By the way, can't a much simpler regex like
/^(\d{8}|\d{13})$/
do the trick?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tux-tn Yeah you're right, the
/^(\d{8}|\d{13})$/
is sufficient to detect a consecutive sequence of 8-digits or 13-digits only ... Forgot about the lookbehind assertions being an ES2018 feature. Thanks! I've just modified it 👍