Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow MAC address with dots #1267

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Allow MAC address with dots #1267

merged 1 commit into from
Mar 12, 2020

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Mar 11, 2020

Network devices like cisco or arista switches use mac address dot notion:

0102.0304.05ab

This allows it to be validated.

ezkemboi
ezkemboi approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@profnandaa
Copy link
Member

@simPod -- thanks for your contrib! 🎉

@profnandaa profnandaa merged commit afafb54 into validatorjs:master Mar 12, 2020
@simPod simPod deleted the allow-dot-mac branch March 12, 2020 17:02
@simPod simPod restored the allow-dot-mac branch March 12, 2020 17:41
@simPod simPod deleted the allow-dot-mac branch June 11, 2020 06:44
@chriso chriso mentioned this pull request Jan 1, 2021
Closed
@simonfan simonfan mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezkemboi ezkemboi ezkemboi approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simPod @profnandaa @ezkemboi