Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added imei #1346

Merged
merged 4 commits into from
Jun 4, 2020
Merged

feat: added imei #1346

merged 4 commits into from
Jun 4, 2020

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented Jun 4, 2020

added a validator for validating imei.
Addresses feature at #1344

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@profnandaa
Copy link
Member

@rubiin -- check the failing builds.

added imei format in readme
@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Jun 4, 2020
@rubiin
Copy link
Member Author

rubiin commented Jun 4, 2020

forgot to include the index file in src

@profnandaa profnandaa removed the 🧹 needs-update For PRs that need to be updated before landing label Jun 4, 2020
@rubiin rubiin requested a review from profnandaa June 4, 2020 07:41
@profnandaa profnandaa merged commit b88334f into validatorjs:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants