Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(isIBAN): add support for EG and SV #1394

Merged
merged 1 commit into from
Jul 27, 2020
Merged

fix(isIBAN): add support for EG and SV #1394

merged 1 commit into from
Jul 27, 2020

Conversation

heanzyzabala
Copy link
Contributor

I added regex for EG and SV and added test for each.

  • EG800002000156789012345180002
  • SV43ACAT00000000000000123123

Some of the IBANs provided in the issue seems to be working as expected:

  • SC52BAHL01031234567890123456USD
  • LC14BOSL123456789012345678901234
  • MT31MALT01100000000000000000123

... so I added them in the tests to prove the validity.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@heanzyzabala heanzyzabala mentioned this pull request Jul 27, 2020
Closed
profnandaa
profnandaa approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa profnandaa merged commit bb7b211 into validatorjs:master Jul 27, 2020
@profnandaa profnandaa mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heanzyzabala @profnandaa