fix isBase64 and isBase32 seeing empty string as invalid, fixes #1418 #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AberDerBart -- Thanks for the PR! 🎉 please remove all the unrelated changes from the diff to make it easy for reviewing. |
Codecov Report
@@ Coverage Diff @@
## master #1419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 95 95
Lines 1254 1254
=========================================
Hits 1254 1254
Continue to review full report at Codecov.
|
|
@profnandaa done. Note that also the code for isBase32 and isBase64 is not generated. |
|
any update on this? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isBase64('') and isBase32('') now return true, which is correct behaviour according to RFC4648
Upon regeneration of the code, there were some additional files changes, I am not sure if this is right, so I made a seperate commit.
Checklist