feat(isMobilePhone): add es-AR locale (Argentina) #1442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this
ghost
reopened this
profnandaa
requested changes
Sep 19, 2020
| @@ -67,6 +67,7 @@ var phones = { | |||
| 'es-MX': /^(\+?52)?(1|01)?\d{10,11}$/, | |||
| 'es-PA': /^(\+?507)\d{7,8}$/, | |||
| 'es-PY': /^(\+?595|0)9[9876]\d{7}$/, | |||
| 'es-AR': /^\+?549(11|[2368]\d)\d{8}$/, | |||
There was a problem hiding this comment.
Tests are failing coz you made your changes in a wrong file, you should make this in src/lib/isMobilePhone.js; and then this will be auto-generated when you run npm test. Please do that, run npm-test then commit and push.
|
closing coz of #1444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argentine phone numbers can be quite varied I found, thankfully mobile phone numbers are more straightforward, I also consulted with some argentinian friends to make sure my regex was working as intended! 😄