fix(isFQDN): allow all-underscore labels with allow_underscores (#1253) #1469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
isFQDN
to allow domain names with all-underscore labels whenallow_underscores
is true. Underscore is not allowed in LDH "preferred name syntax" host names, but may appear anywhere in generic domain name labels (cf. RFC 8499).Checklist
README updated (where applicable)