Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added phones for lebanon, georgia and peru #1473

Merged
merged 1 commit into from
Oct 9, 2020
Merged

added phones for lebanon, georgia and peru #1473

merged 1 commit into from
Oct 9, 2020

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented Oct 8, 2020

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@rubiin
Copy link
Member Author

rubiin commented Oct 8, 2020

@profnandaa i have mixed all three phone prs into one. Please look into it asap

@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited
Loading

Codecov Report

Merging #1473 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1473   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1275     1275           
=======================================
  Hits         1274     1274           
  Misses          1        1
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d61d4c...b799846. Read the comment docs.

profnandaa
profnandaa approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@profnandaa profnandaa merged commit 6346f99 into validatorjs:master Oct 9, 2020
@profnandaa profnandaa changed the title added phones for lenabnon,georgia and peru added phones for lebanon, georgia and peru Oct 9, 2020
@profnandaa profnandaa mentioned this pull request Nov 29, 2020
Merged
This was referenced Mar 12, 2021
Open
Closed
This was referenced Apr 25, 2021
Closed
Closed
This was linked to issues Apr 25, 2021
Valid phone number from Lebanon #1414
Closed
Valid phone number from Georgia #1415
Closed
@tux-tn tux-tn mentioned this pull request Apr 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valid phone number from Georgia Valid phone number from Lebanon
2 participants
@rubiin @profnandaa