Malaysian Passport validation #1501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stranger26
force-pushed
the
MY-Passport
branch
from
ad96b0c
to
79de297
Compare
Codecov Report
@@ Coverage Diff @@
## master #1501 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1277 1277
=======================================
Hits 1276 1276
Misses 1 1
Continue to review full report at Codecov.
|
tux-tn
requested changes
Nov 20, 2020
profnandaa
previously approved these changes
Nov 29, 2020
profnandaa
added
the
mc-to-land
ezkemboi
requested changes
Dec 13, 2020
ezkemboi
approved these changes
Dec 16, 2020
|
@stranger26 -- some more merge conflicts... |
|
Will re-open the pull request help? I think the conflict came in the second commit, or will squashing my commits do the job? |
|
Sorry, it was caused by another merge. We are working on something to minimize these kind of conflicts; soonest. |
3 tasks
|
@profnandaa @ezkemboi reopened in #1574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Malaysian Passport validation
Checklist