Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat Add support for Angola mobile phone numbers #1505

Merged
merged 4 commits into from
Dec 8, 2020

Conversation

AdilsonFuxe
Copy link
Contributor

@AdilsonFuxe AdilsonFuxe commented Oct 27, 2020

{{ briefly describe what you have done in this PR }}

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1505 (ee3e4cd) into master (5810e36) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1505   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines         1773      1773           
=========================================
  Hits          1773      1773           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5810e36...ee3e4cd. Read the comment docs.

src/lib/isMobilePhone.js Show resolved Hide resolved
@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Nov 19, 2020
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉 Please fix the merge conflict, and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Nov 29, 2020
@profnandaa profnandaa merged commit dc05855 into validatorjs:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing. 🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants