Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isPostalCode): Add CN (China) postalCode validator and test. #1534

Merged
merged 3 commits into from
Nov 29, 2020

Conversation

httpsbao
Copy link
Contributor

Hello, I add CN (China) postalCode validator and test.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #1534 (727cdf0) into master (7ef0f25) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1534   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           98        98           
  Lines         1763      1763           
=========================================
  Hits          1763      1763           
Impacted Files Coverage Δ
src/lib/isPostalCode.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef0f25...727cdf0. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contrib ! LGTM for most part 🎉
Just a little request: Can you discard your changes to auto-generated files ( index.js, validator.js and validator.min.js )

(index.js, validator.js,validator.min.js)
Copy link
Contributor Author

@httpsbao httpsbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more changes in index.js, validator.js and validator.min.js

@httpsbao
Copy link
Contributor Author

httpsbao commented Nov 28, 2020

Thank you for your contrib ! LGTM for most part 🎉
Just a little request: Can you discard your changes to auto-generated files ( index.js, validator.js and validator.min.js )

@tux-tn

Thankyou, done!

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants