-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isPostalCode): Add CN (China) postalCode validator and test. #1534
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1534 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 98 98
Lines 1763 1763
=========================================
Hits 1763 1763
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contrib ! LGTM for most part 🎉
Just a little request: Can you discard your changes to auto-generated files ( index.js
, validator.js
and validator.min.js
)
(index.js, validator.js,validator.min.js)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more changes in index.js
, validator.js
and validator.min.js
Thankyou, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 🎉
Hello, I add CN (China) postalCode validator and test.
Checklist