Setup github actions #1553
Setup github actions #1553
Conversation
|
@tux-tn -- thanks so much for such a thorough job on this one! So that we do testing with pseudo-releases, I have created a temp branch, |
|
/cc. @chriso |
|
@profnandaa my pleasure! base branch has been changed to releases |
…rjs#1554) * fix(isMobilePhone): update de-CH locale (validatorjs#1549) feat(isMobilePhone): add fr-CH locale (validatorjs#1549) feat(isMobilePhone): add it-CH locale (validatorjs#1549) * fix(isMobilePhone): update de-CH, fr-CH and it-CH locale in validator.min.js(validatorjs#1549) * fix(isMobilePhone): update fr-CH and it-CH locale aliases (validatorjs#1549) Co-authored-by: Ashutosh Kumar <[email protected]>
* Added isLicensePlate check with german locale * de-LI (Liechtenstein) validator * Added albanian number plates * reversed changes in index.js * reversed changes in index.js * Refactored de-DE into one big regex, expanded tests fot de-DE * added pt-PT locale * Fixed coverage problem * feat(isLicensePlate): clean build * coverage is now 100% * Update README.md * Update README.md
Add correct tax identifier to demonstrate issue and fix. Thanks to: Panos Papadopoulos
…lidatorjs#1575) * Support new VN mobile phone 087 (https://didong.itelecom.vn/) * Add test for new telco number Co-authored-by: Kyle Dinh <[email protected]>
.github/workflows/ci.yml
Outdated
| branches: [master] | ||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Should we use some specific version instead of latest for stability?
There was a problem hiding this comment.
latest tag is for the latest Ubuntu LTS version but i agree with you, i will set it to ubuntu-20.04
There was a problem hiding this comment.
Sorry for my awefully long delay on this @tux-tn ; This LGTM. Thanks for the work!
|
@tux-tn -- sorry missed on this, could you do the PR against |
Migrated from Travis-ci to github action for CI jobs
The main reason is that travis-ci.org is closing on 31 December and travis-ci.com have limits for open source projects. For more info you can check this article .
CI pipelines are triggered by new pull requests and pushes to master branch. Tests are run on multiple Node.js versions (14, 12, 10, 8) and coverage is sent to codecov after the tests succeed (only one time in the Node.js 14 pipeline).
You can find below example of action pipeline:
Setup automatic npm publishing
As discussed in #1540 , i created a new github action to publish a new version to npm registry on new release (the publishing happens only when a release is created). The main goal is to prevent having missing files or broken versions published.
In order to test this feature, i created a scoped package @validatorjs/validator-dev (Don't use this package, it's for demo purpose only).
@profnandaa The only change that we need to make is to create a new secret named
NPM_SECRETcontaining as the name may suggest a generated npm access token (The type need to be automation to bypass 2 Factor Auth) with write access to the package.Other changes
validator.jsandvalidator.min.jsauto-generated fileschriso/validator.jswithvalidatorjs/validator.jsin all urls to prevent unnecessary HTTP redirectsrc/index.jswould be ignored by.gitignoreChecklist