-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IR passport and identityCard, respect .gitignore files #1595
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1595 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1843 1852 +9
=========================================
+ Hits 1843 1852 +9
Continue to review full report at Codecov.
|
Co-authored-by: Federico Ciardi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR @mhf-ir and sorry for the long review delay!
Your additions to isIdentityCard
and isPassportNumber
are good to go;
I'm not sure about adding isLuhn
as a standalone validator, i don't see a big usage outside of credit card number validation (isCreditCard
is already using it internally) and we should probably open this for discussion and wait for @ezkemboi , @profnandaa and the rest of the community feedback.
@tux-tn As i Said previously isLuhn one of the most important validation that you can see in npm many version (about 50 package) of that is implemented.
Forget about isCreditCard, it's Independent validation for Luhn algorithm that developers need it already. Dependency of isCreditCard is out of this PR scope. isCreditCard might be depend on Luhn or not, but could be different issue and PR.
|
After all I can remove isLuhn and send another issue and PR. Is that OK? @tux-tn |
it's a good compromise, it will allow us to land directly IR Passport/IdentityCard validator and open discussion concerning the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thank you again @mhf-ir for taking the time to fix conflicts and make the necessary changes!
@mhf-ir feel free to open a new PR concerning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉
IR
for isPassportNumberIR
for isIdentityCardChecklist