Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rephrase sentence for grammatical correctness #1620

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

prahaladbelavadi
Copy link
Contributor

Change Text from "Passing anything other than a string is an error." to "Passing anything other than a string will result in an error."

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated

Change Text from "Passing anything other than a string is an error." to "Passing anything other than a string will result in an error."
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #1620 (8919e26) into master (2331120) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1620   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1798      1798           
=========================================
  Hits          1798      1798           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2331120...7de02dd. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 ! Thank you for the fix @prahaladbelavadi

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Mar 2, 2021
@prahaladbelavadi
Copy link
Contributor Author

Happy to help @tux-tn 😄

@profnandaa profnandaa merged commit 022b100 into validatorjs:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants