-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: npm installation error #1697
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1697 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 1855 1862 +7
=========================================
+ Hits 1855 1862 +7
Continue to review full report at Codecov.
|
rollup latest version doesnot seem to support older versions. Also node 6.0 is way old i think we should drop tests for it as its likely someone is using that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if node 6 may not be used anymore this is a breaking change and should be released in a new major.
however its a blocker if you cant install the package dependencies after forking. @profnandaa |
tested on node v10,12 and v14. |
Don't leave out Node 6 yet, there's a time it helped us catch an old browser incompatibility, see #1357 |
@profnandaa fixed it without breaking support for node 6 |
@rubiin -- thanks! |
@profnandaa should i also make a pr to update eslint and some tools. They are way old |
Updated rollup to solve installation error
Checklist