Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (isMobilePhone) Add mobile phone validation for Cameroon (fr-CM) #1772

Merged
merged 11 commits into from
Oct 31, 2021
Merged

feat: (isMobilePhone) Add mobile phone validation for Cameroon (fr-CM) #1772

merged 11 commits into from
Oct 31, 2021

Commits on Oct 10, 2021

  1. Add Cameroon validation regex 

    I have added a regex for validating Cameroonian mobile numbers which should work. I'm not super comfortable with regular expressions, so if I have screwed something up, please let me know. I have done some basic testing and it has functioned fine thus far.
    @tarob0ba
    tarob0ba authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    1c89471 View commit details
    Browse the repository at this point in the history

  2. Update README to include fr-CM in isMobilePhone

    @tarob0ba
    tarob0ba authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    1152440 View commit details
    Browse the repository at this point in the history

  3. Add (very) basic testing for Cameroonian mobile number

    @tarob0ba
    tarob0ba authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    822b212 View commit details
    Browse the repository at this point in the history

  4. Fix missing brace (whoops!)

    @tarob0ba
    tarob0ba authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    44ae45a View commit details
    Browse the repository at this point in the history

  5. Fix commas (I hope)

    @tarob0ba
    tarob0ba authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    e7d32ae View commit details
    Browse the repository at this point in the history

  6. Fix sloppy tests 

    Fix my sloppy tests. I'm really tired and probably should not be working on this, but I accidentally added an extra digit while typing.
    @tarob0ba
    tarob0ba authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    b01fa08 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Update regex for correctness 

    Add mobile prefix (6) to regex, remove space allowance, and optimize regex
    @tarob0ba
    tarob0ba authored Oct 18, 2021
    Configuration menu
    Copy the full SHA
    86720d8 View commit details
    Browse the repository at this point in the history

  2. Update tests for correctness

    @tarob0ba
    tarob0ba authored Oct 18, 2021
    Configuration menu
    Copy the full SHA
    c62fe96 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Remove invalid space 

    Sorry!
    @tarob0ba
    tarob0ba authored Oct 19, 2021
    Configuration menu
    Copy the full SHA
    a0c6226 View commit details
    Browse the repository at this point in the history

  2. Rerun failed tests (internal server error)

    @tarob0ba
    tarob0ba authored Oct 19, 2021
    Configuration menu
    Copy the full SHA
    9926f9e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. Merge branch 'master' into patch-1

    @tarob0ba
    tarob0ba authored Oct 30, 2021
    Configuration menu
    Copy the full SHA
    374724a View commit details
    Browse the repository at this point in the history