Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): add Guyana en-GY locale #1784

Conversation

mfkrause
Copy link
Contributor

Adds support for mobile phone numbers from Guyana.

cc #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #1784 (9030828) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1784   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...9030828. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you for your contribution

@tux-tn tux-tn added hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Oct 22, 2021
@profnandaa
Copy link
Member

@mfkrause -- pls fix the merge conflict on README and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021
@profnandaa profnandaa changed the title feat: (isMobilePhone) Add Guyana mobile phone validation feat(isMobilePhone): add Guyana en-GY locale Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] fixed merge conflicts in #1784

feat: (isMobilePhone) Add Guyana mobile phone validation

Fix linter errors
@profnandaa
Copy link
Member

Your commit is now included here #1851

@profnandaa profnandaa closed this Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] fixed merge conflicts in #1784

feat: (isMobilePhone) Add Guyana mobile phone validation

Fix linter errors
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] fixed merge conflicts in #1784

feat: (isMobilePhone) Add Guyana mobile phone validation

Fix linter errors
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] fixed merge conflicts in #1784

feat: (isMobilePhone) Add Guyana mobile phone validation

Fix linter errors
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] fixed merge conflicts in #1784

feat: (isMobilePhone) Add Guyana mobile phone validation

Fix linter errors
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] fixed merge conflicts in #1784

feat: (isMobilePhone) Add Guyana mobile phone validation

Fix linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants