Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isIdentityCard): Add isIdentityCard 'LK' (Sri Lanka) locale #1786

Merged
merged 4 commits into from
Oct 30, 2021
Merged

feat(isIdentityCard): Add isIdentityCard 'LK' (Sri Lanka) locale #1786

merged 4 commits into from
Oct 30, 2021

Conversation

nimanthadilz
Copy link
Contributor

I have added the validation for Sri Lanka's NIC (National Identity Card) in isIdentityCard validator. Both old and new NIC numbers are validated and tests are provided.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #1786 (3525238) into master (13651ea) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1786   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2035    +6     
  Branches       457       459    +2     
=========================================
+ Hits          2029      2035    +6
Impacted Files Coverage Δ
src/lib/isIdentityCard.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...3525238. Read the comment docs.

@nimanthadilz
Copy link
Contributor Author

Hi, I would like to know why "Run tests on Node.js 6" is failing and how to fix that.

@tux-tn
Copy link
Member

tux-tn commented Oct 15, 2021

@nimanthadilz the issue was related to a broken dependency, it has been fixed and your pipeline passed on Node.js 6

tux-tn
tux-tn requested changes Oct 25, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @nimanthadilz ! Mostly LGTM, i added a little comment that need to be adressed.

src/lib/isIdentityCard.js Outdated Show resolved Hide resolved
@tux-tn tux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Oct 25, 2021
@nimanthadilz @tux-tn
Change let to const
3525238 
Co-authored-by: Sarhan Aissi <[email protected]>
@nimanthadilz
Copy link
Contributor Author

I committed the changes requested. This contribution was done as part of Hacktoberfest. It's a pleasure to contribute to opensource.

tux-tn
tux-tn approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you

@tux-tn tux-tn added hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed and removed 🧹 needs-update For PRs that need to be updated before landing labels Oct 26, 2021
profnandaa
profnandaa approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib! 🎉

@profnandaa profnandaa merged commit dc9f843 into validatorjs:master Oct 30, 2021
theteladras pushed a commit to theteladras/validator.js that referenced this pull request Oct 30, 2021
@nimanthadilz @tux-tn @theteladras
feat(isIdentityCard): add 'LK' (Sri Lanka) locale (validatorjs#1786)
52fa6a8 
* Implement isIdentityCard LK(Sri Lanka) locale

* Add tests for isIdentityCard LK locale

* Update README.md for the isIdentityCard LK locale

* Change let to const

Co-authored-by: Sarhan Aissi <[email protected]>

Co-authored-by: Sarhan Aissi <[email protected]>
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@nimanthadilz @tux-tn @profnandaa
feat(isIdentityCard): add 'LK' (Sri Lanka) locale (#1786)
dac5814 
* Implement isIdentityCard LK(Sri Lanka) locale

* Add tests for isIdentityCard LK locale

* Update README.md for the isIdentityCard LK locale

* Change let to const

Co-authored-by: Sarhan Aissi <[email protected]>

Co-authored-by: Sarhan Aissi <[email protected]>
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@nimanthadilz @tux-tn @profnandaa
feat(isIdentityCard): add 'LK' (Sri Lanka) locale (#1786)
e83a6eb 
* Implement isIdentityCard LK(Sri Lanka) locale

* Add tests for isIdentityCard LK locale

* Update README.md for the isIdentityCard LK locale

* Change let to const

Co-authored-by: Sarhan Aissi <[email protected]>

Co-authored-by: Sarhan Aissi <[email protected]>
@profnandaa profnandaa mentioned this pull request Oct 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tux-tn tux-tn tux-tn approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
🎉 first-pr hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nimanthadilz @tux-tn @profnandaa