Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Poland Country Code #1809

Merged
merged 4 commits into from
Oct 30, 2021
Merged

Updated Poland Country Code #1809

merged 4 commits into from
Oct 30, 2021

Conversation

Ronqn
Copy link
Contributor

@Ronqn Ronqn commented Oct 19, 2021

Updated the country code of Poland from PO to PL.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Fixes #1806

EDIT : First check failed because I forgot to edit the validator.js file. All good now!
EDIT 2 : Also updated README.md... my bad

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1809 (a08e1bb) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1809   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...a08e1bb. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @Ronqn ! Mostly LGTM. Please check and address my comment!

README.md Outdated Show resolved Hide resolved
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 ! Don't know why github showed my an old revision of your README.md

@Ronqn
Copy link
Contributor Author

Ronqn commented Oct 19, 2021

Thanks for accepting, I noticed the typo after replacing and quickly fixed it, the check probably bugged at that time :-)

👍🏻

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! 🎉

@profnandaa profnandaa merged commit a837e6f into validatorjs:master Oct 30, 2021
theteladras pushed a commit to theteladras/validator.js that referenced this pull request Oct 30, 2021
* Updated Poland Country Code

* Updated PO to PL in validator.js

* Changed PO to PL in README.md

* Typo in README.md

Co-authored-by: Ronan Doudiès <[email protected]>
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* Updated Poland Country Code

* Updated PO to PL in validator.js

* Changed PO to PL in README.md

* Typo in README.md

Co-authored-by: Ronan Doudiès <[email protected]>
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* Updated Poland Country Code

* Updated PO to PL in validator.js

* Changed PO to PL in README.md

* Typo in README.md

Co-authored-by: Ronan Doudiès <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid country code for Poland
3 participants