Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): regex for Burkina Faso fr-BF and Namibia en-NA locales #1834

Closed
wants to merge 8 commits into from

Conversation

ZeeMangena
Copy link
Contributor

Add new regex for Burkina Faso (fr-BF) mobile phone numbers in isMobilePhone

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1834 (2d2c929) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1834   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...2d2c929. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib. I'll update the title to include Namibia

@@ -41,6 +41,7 @@ const phones = {
'en-KE': /^(\+?254|0)(7|1)\d{8}$/,
'en-MT': /^(\+?356|0)?(99|79|77|21|27|22|25)[0-9]{6}$/,
'en-MU': /^(\+?230|0)?\d{8}$/,
'en-NA': /^(\+?264|0)(6|8)\d{7}$/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scratch that, seen your changes below; perhaps you can have this change as separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, never mind, I'll just update the title of the PR to include both Namibia and BF.

@profnandaa profnandaa changed the title feat(isMobilePhone): regex for Burkina Faso locale feat(isMobilePhone): regex for Burkina Faso and Namibia locales Oct 30, 2021
@profnandaa
Copy link
Member

@ZeeMangena -- please fix the merge conflict and we should be good to go.

@profnandaa profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr hacktoberfest-accepted labels Oct 30, 2021
@profnandaa profnandaa changed the title feat(isMobilePhone): regex for Burkina Faso and Namibia locales feat(isMobilePhone): regex for Burkina Faso fr-BF and Namibia en-NA locales Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
…ocales

chore: squashed commits from #1834

feat(isMobilePhone): regex for Namibia locale

fix(isMobilePhone): removing telephone validation

fix(isMobliePhone): regex now validates as intended

fix(isMobilePhone): requiring phone number prefixes in validation

feat(isMobilePhone): regex for Burkina Faso locale

fix(isMobilePhone): removing code intended for a different branch

fix(isMobilePhone): Making plus sign optional

feat(isMobilePhone): regex for Burkina Faso locale
@profnandaa
Copy link
Member

This changed has now been added here #1851 // however, please proceed and merge the rest of your work into one PR. Thanks so much for your contributions! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants