-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isUUID) - Add support for validation of version v1 and v2 #1848
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2052 2052
Branches 463 463
=========================================
Hits 2052 2052
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Thank you for your PR !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉
* fix(isUUID) for null version argument supply * improve(isUUID) validation for version 1 and 2
* fix(isUUID) for null version argument supply * improve(isUUID) validation for version 1 and 2
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
…Typed#65406) New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
Added validation support for UUID version 1 and version 2. Also a minor fix was made for returning undefined instead of returning a boolean.
Checklist