fix(isMobilePhone): Fix en-BM matching invalid numbers due to missing end-of-string anchor #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2335 2335
Branches 586 586
=========================================
Hits 2335 2335
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
braaar
previously approved these changes
Dec 7, 2022
WikiRik
previously approved these changes
Dec 13, 2022
rubiin
previously approved these changes
Jan 21, 2023
profnandaa
added
the
mc-to-land
that one particular number combination was missing the `$` end-of-string anchor, which caused the bug validatorjs#2115 fixes validatorjs#2115
pano9000
force-pushed
the
fix_en-BM_isMobilePhone
branch
from
d7a142f
to
b2249b6
Compare
WikiRik
approved these changes
Jan 28, 2023
rubiin
approved these changes
Jan 29, 2023
rubiin
removed
the
mc-to-land
profnandaa
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #2115
Fix this by adding the missing end-of-string anchor to the RegExp.
quick side note:
the regExp can be even simplified a bit more to the following version
^(\+?1)?441(((3|7)\d{6})|(5[0-39]\d{5}))$, which still passes all tests, but is shorter, however since this is more a quick bug fix, I did not include this in my commit, but sticked to using the existing format.Fixes #2115
Checklist
[ ] README updated (where applicable)