Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isEmail) extend to enable allow_underscores in domain #2229

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

guspower
Copy link
Contributor

Allow successful validation of email addresses containing domains with underscores

Add allow_underscores option to isEmail, pass through value to isFQDN validator.

An example underscore domain in the wild for reference

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable) (N/A)

Gus Power added 2 commits May 24, 2023 15:27
…tion, allowing successful validation of email addresses containing domains with underscores
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9ba1735) 99.95% compared to head (0904c28) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2229   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2405     2405           
  Branches      604      604           
=======================================
  Hits         2404     2404           
  Partials        1        1           
Impacted Files Coverage Δ
src/lib/isEmail.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guspower
Copy link
Contributor Author

thanks for the review @WikiRik +1

@krichards
Copy link

This would be really helpful.

@guspower
Copy link
Contributor Author

thanks for the review @rubiin +1

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

@profnandaa profnandaa merged commit 6be9634 into validatorjs:master Aug 3, 2023
Copy link

@zhaoge068 zhaoge068 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants