Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation Hyphen before year is not allowed #2381

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Add validation Hyphen before year is not allowed #2381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a49a17
Add validation Hyphen before year is not allowed
Sumit-tech-joshi Mar 24, 2024
309c958
Add invalid test case for is date function
Sumit-tech-joshi Mar 29, 2024
eadfad4
Added missing coma
Sumit-tech-joshi Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lib/isDate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function zip(date, format) {
}

export default function isDate(input, options) {
if (typeof options === 'string') { // Allow backward compatbility for old format isDate(input [, format])
if (typeof options === 'string') { // Allow backward compatibility for old format isDate(input [, format])
options = merge({ format: options }, default_date_options);
} else {
options = merge(options, default_date_options);
Expand All @@ -49,6 +49,11 @@ export default function isDate(input, options) {

let fullYear = dateObj.y;

// Check if the year starts with a hyphen
if (fullYear.startsWith('-')) {
return false; // Hyphen before year is not allowed
}

if (dateObj.y.length === 2) {
const parsedYear = parseInt(dateObj.y, 10);

Expand Down
2 changes: 2 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12957,6 +12957,8 @@ describe('Validators', () => {
'2019-02-29', // non-leap year
'2020-04-31', // invalid date
'2020/03-15', // mixed delimiter
'-2020-04-19',
'-2023/05/24',
],
});
test({
Expand Down
Loading