-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Regular Expression for Validating Panamanian Phone Numbers #2434
base: master
Are you sure you want to change the base?
Updating Regular Expression for Validating Panamanian Phone Numbers #2434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally put initial and ending quotes to the regular expression, already fixed.
… and also added support for numbers not starting with +
@Nauj-Montes also add source for the update |
That means that I have to put the reference from which new changes are based on, right? |
Yeah . Source like a wikipedia entry or perhaps a webpage would be good. Will be helpful for review |
thanks for the PR. |
To resolve the issue #2433, the regular expression was be updated to:
Benefits of the Updated Regex:
+507
at the start.+507 6123-4567
are valid.Signed-off-by: Juan Montes [email protected]