Fixed #2438 isEmail Issue #2446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're correctly validated as valid, though - why do you say it's incorrect? https://en.wikipedia.org/wiki/Email_address#Local-part |
rubiin
added
blocked
|
Closing in favor of above comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2445 fixed(isEmail): Correct validation for invalid characters in quoted strings
This PR addresses the issue described in issue #2438, where email addresses with invalid characters such as
*and.enclosed within double quotes were incorrectly validated as valid. TheisEmailfunction's regular expression for quoted strings was updated to comply with RFC 5321, allowing only valid characters within quotes.**References
Checklist
"example*."@gmail.comare now rejected).