Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to MasterCard's 2-Series BINs #576

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Add support to MasterCard's 2-Series BINs #576

merged 1 commit into from
Sep 6, 2016

Conversation

andyautida14
Copy link

Here are some details regarding MasterCard's 2-Series BINs:
https://icepay.com/2016/08/04/mastercard-introduces-new-2-series-bin-range/

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.104% when pulling 800dded on andyautida14:master into 9208844 on chriso:master.

@chriso
Copy link
Collaborator

chriso commented Sep 6, 2016

Thanks.

@chriso chriso merged commit 1d3b44f into validatorjs:master Sep 6, 2016
@chriso
Copy link
Collaborator

chriso commented Sep 6, 2016

The tests currently fail with:

  1) Validators should validate credit cards:
     Error: validator.isCreditCard(2222155765072228) failed but should have passed
      at test/validators.js:19:15
      at Array.forEach (native)
      at test (test/validators.js:14:19)
      at Context.<anonymous> (test/validators.js:1588:5)

chriso added a commit that referenced this pull request Sep 6, 2016
@chriso
Copy link
Collaborator

chriso commented Sep 6, 2016

Actually nm, you need to update src/lib/isCreditCard.js rather than the compiled lib/isCreditCard.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants