isMobilePhone: add option for strictMode #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
force-pushed
the
feat-741-is-phone-number-cc
branch
from
3091a4b
to
d92b200
Compare
|
Will fix the m/c. |
This commit adds an option on isMobilePhone to allow for strict strict checking of mobile phone numbers, i.e. must start with '+<country-code>' fixes validatorjs#741
andela-anandaa
force-pushed
the
feat-741-is-phone-number-cc
branch
from
d92b200
to
5615a12
Compare
|
@chriso - fixed the m/c and added a tiny step on the contribution instructions (README). I think after step 5 (fixing of any merge conflicts), someone is supposed to run the tests again and make sure that all is okay (and builds are run too) before pushing. |
|
Great, thanks @profnandaa! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an option on isMobilePhone to allow for strict
strict checking of mobile phone numbers, i.e. must start with
'+'
fixes #741