Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for IP address email validation #800 #845

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Adding support for IP address email validation #800 #845

merged 3 commits into from
Jul 31, 2018

Conversation

CodingNagger
Copy link
Contributor

No description provided.

@profnandaa
Copy link
Member

profnandaa commented Jun 15, 2018 •
edited
Loading

Suggestion, could this be optional through the options object passed to the isEmail function? An option like allow_ip or something... Since for general purpose, we rarely use IP's in emails. See my previous comment here too - #800 (comment)

@CodingNagger
Copy link
Contributor Author

Hi @profnandaa that makes sense, we may have people wanting to exclude IPs by default as it is the existing behaviour. Updating that.

@CodingNagger
Copy link
Contributor Author

Hey @chriso, any chance to check that out?

@chriso
Copy link
Collaborator

chriso commented Jul 31, 2018

Thanks for the PR 😄

@chriso chriso merged commit 9cd99d6 into validatorjs:master Jul 31, 2018
@chriso chriso mentioned this pull request Jul 31, 2018
Closed
chriso added a commit that referenced this pull request Jul 31, 2018
@chriso
Updates for #845
79a74a2
@CodingNagger
Copy link
Contributor Author

No worries @chriso 😄

@abdulrahman-khankan abdulrahman-khankan mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CodingNagger @profnandaa @chriso @BJSS-JD