Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added slovenian locale #896

Merged
merged 5 commits into from
Sep 24, 2018
Merged

Added slovenian locale #896

merged 5 commits into from
Sep 24, 2018

Conversation

SloCompTech
Copy link
Contributor

Hi,
I added slovenian locale to alpha.js.

@chriso
Copy link
Collaborator

chriso commented Sep 22, 2018

Thanks. Can you update the README?

@SloCompTech
Copy link
Contributor Author

Sure thing

@SloCompTech
Added sl-SI to isAlpha and isAlphaNumeric
5e2a0fa 
Added `sl-SI` to README.md
@SloCompTech
Added slovenian isMobilePhone
1ae2254 
Added slovenian format for phones
@SloCompTech
Copy link
Contributor Author

I updated Readme and also added slovenian format for phone numbers, do I need to update package version too ?

profnandaa
profnandaa approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa
Copy link
Member

@SloCompTech - thanks! No need to update the version 👍

@chriso chriso merged commit a9ea6b1 into validatorjs:master Sep 24, 2018
@profnandaa
Copy link
Member

@SloCompTech - thanks for getting your first contribution in! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SloCompTech @chriso @profnandaa