Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add default property #961

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Always add default property #961

merged 2 commits into from
Jan 15, 2019

Conversation

lukepolo
Copy link
Contributor

@lukepolo lukepolo commented Jan 15, 2019 •
edited by chriso
Loading

This allows to use of require or import correctly.

This fixes #957

lukepolo and others added 2 commits January 15, 2019 14:39
@lukepolo
Always add default property
543fe41 
This allows to use of require or import correctly.

#957
@lukepolo
Updating files to use addDefaultProperty
909588e
@chriso
Copy link
Collaborator

chriso commented Jan 15, 2019

Good catch, thanks! Can you run npm test to re-compile the code?

@chriso chriso added the 🧹 needs-update For PRs that need to be updated before landing label Jan 15, 2019
@lukepolo
Copy link
Contributor Author

All tests pass !
image

@lukepolo
Copy link
Contributor Author

Want me to update the lib and commit it?

@chriso
Copy link
Collaborator

chriso commented Jan 15, 2019

That looks good now, thanks.

@chriso chriso merged commit c8bb935 into validatorjs:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import is inconsistent
2 participants
@lukepolo @chriso