Apply suggestions from code review

Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: jonathanl-bq <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
valkey-io · Sep 12, 2024 · 8b29313 · 8b29313
1 parent dde0f7f
commit 8b29313
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,5 @@
 #### Changes
-* Node: Added `invokeScript` API for cluster client ([#2284](https://github.com/valkey-io/valkey-glide/pull/2284))
+* Node: Added `invokeScript` API with routing for cluster client ([#2284](https://github.com/valkey-io/valkey-glide/pull/2284))
 * Python: Replace instances of Redis with Valkey ([#2266](https://github.com/valkey-io/valkey-glide/pull/2266))
 * Java: Replace instances of Redis with Valkey ([#2268](https://github.com/valkey-io/valkey-glide/pull/2268))
 * Node: Replace instances of Redis with Valkey ([#2260](https://github.com/valkey-io/valkey-glide/pull/2260))

diff --git a/node/src/GlideClusterClient.ts b/node/src/GlideClusterClient.ts
@@ -1443,7 +1443,7 @@ export class GlideClusterClient extends BaseClient {
     }
 
     /**
-     * Invokes a Lua script with its keys and arguments.
+     * Invokes a Lua script with arguments.
      * This method simplifies the process of invoking scripts on a Valkey server by using an object that represents a Lua script.
      * The script loading, argument preparation, and execution will all be handled internally. If the script has not already been loaded,
      * it will be loaded automatically using the `SCRIPT LOAD` command. After that, it will be invoked using the `EVALSHA` command.

diff --git a/node/tests/GlideClusterClient.test.ts b/node/tests/GlideClusterClient.test.ts
@@ -1488,8 +1488,9 @@ describe("GlideClusterClient", () => {
                             client.close();
                         }
                     });
+
                     it(
-                        "invoke script invokeScript %p",
+                        "invoke script with route invokeScriptWithRoute %p",
                         async () => {
                             const client =
                                 await GlideClusterClient.createClient(