Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: FAILED script kill killable test #2625

Closed
ikolomi opened this issue Nov 6, 2024 · 1 comment
Closed

Node: FAILED script kill killable test #2625

ikolomi opened this issue Nov 6, 2024 · 1 comment
Assignees
@barshaul
Labels
bug Something isn't working Flaky-tests Flaky-tests node Node.js wrapper Release blocker Can't release without. testing Everything about testing
Milestone
1.2

Comments

@ikolomi
Copy link
Collaborator

ikolomi commented Nov 6, 2024

Describe the bug

CI links:
https://github.com/valkey-io/valkey-glide/actions/runs/11701901352/job/32588995457#step:5:982

Expected Behavior

.

Current Behavior

.

Reproduction Steps

.

Possible Solution

No response

Additional Information/Context

No response

Client version used

release-1.2

Engine type and version

.

OS

.

Language

TypeScript

Language Version

.

Cluster information

No response

Logs

No response

Other information

No response
@ikolomi ikolomi added bug Something isn't working Release blocker Can't release without. node Node.js wrapper testing Everything about testing Flaky-tests Flaky-tests labels Nov 6, 2024
@ikolomi ikolomi added this to the 1.2 milestone Nov 6, 2024
@ikolomi ikolomi assigned avifenesh and barshaul and unassigned avifenesh Nov 6, 2024
@barshaul barshaul mentioned this issue Nov 6, 2024
Merged
6 tasks
@barshaul
Copy link
Collaborator

barshaul commented Nov 7, 2024

Fixed in #2629

@barshaul barshaul closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barshaul barshaul

Labels
bug Something isn't working Flaky-tests Flaky-tests node Node.js wrapper Release blocker Can't release without. testing Everything about testing
Projects
Valkey-GLIDE - internal
Status: Done
Milestone
1.2
Development

No branches or pull requests
3 participants
@avifenesh @barshaul @ikolomi