Node: Changed SCRIPT KILL test to only test the command works, not that the script is actually being killed

[barshaul]

Changed Node's SCRIPT KILL test to test only that the command works, not that a script is actually being killed (to test the client and not the server). Moved to SharedTests.

Issue link

This Pull Request is linked to issue (URL): closes #2625

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one issue.
• Commit message has a detailed description of what changed and why.
• Tests are added or updated.
• CHANGELOG.md and documentation files are updated.
• Destination branch is correct - main or release
• Commits will be squashed upon merging.

[Yury-Fridlyand]

We discussed these tests with the team. The approach in these tests is incorrect in general - we're trying to test the server, instead of testing the client.

valkey-glide/node/tests/GlideClient.test.ts

Lines 1478 to 1480 in 76a5c10

	await expect(client1.scriptKill()).rejects.toThrow(
	"No scripts in execution right now",
	);

This simple check is enough to test the client, all the rest can (should) be removed.
Keep in mind that we have the same test for python and java clients too. Fix them as well.

[barshaul]

We discussed these tests with the team. The approach in these tests is incorrect in general - we're trying to test the server, instead of testing the client.

valkey-glide/node/tests/GlideClient.test.ts

Lines 1478 to 1480 in 76a5c10

	await expect(client1.scriptKill()).rejects.toThrow(
	"No scripts in execution right now",
	);

This simple check is enough to test the client, all the rest can (should) be removed. Keep in mind that we have the same test for python and java clients too. Fix them as well.

good point!

[avifenesh]

Do we think that this test is not relevant at all?
Is it true for what @shohamazon is working on as well?