Python: Added STRLEN command in python #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilboaAWS
force-pushed
the
main
branch
2 times, most recently
from
0372ee7
to
27f8d54
Compare
|
|
||
| Returns: | ||
| int: The length of the string value stored at key. | ||
| If `key` does not exist, it is interpreted as an empty list and 0 is returned. |
There was a problem hiding this comment.
Suggested change
| If `key` does not exist, it is interpreted as an empty list and 0 is returned. | |
| If `key` does not exist, it is interpreted as an empty string and 0 is returned. |
|
|
||
| Commands response: | ||
| int: The length of the string value stored at key. | ||
| If `key` does not exist, it is interpreted as an empty list and 0 is returned. |
There was a problem hiding this comment.
Suggested change
| If `key` does not exist, it is interpreted as an empty list and 0 is returned. | |
| If `key` does not exist, it is interpreted as an empty string and 0 is returned. |
| assert await redis_client.lpush(key1, value_list) == 4 | ||
| with pytest.raises(RequestError) as e: | ||
| assert await redis_client.strlen(key1) | ||
| assert "Operation against a key holding the wrong kind of value" in str(e) |
There was a problem hiding this comment.
keep in mind that different redis version return different error message
shohamazon
requested changes
Apr 7, 2024
| @@ -1042,6 +1042,24 @@ async def llen(self, key: str) -> int: | |||
| """ | |||
| return cast(int, await self._execute_command(RequestType.LLen, [key])) | |||
|
|
|||
| async def strlen(self, key: str) -> int: | |||
| """ | |||
| Get the length of the string value stored at key. | |||
There was a problem hiding this comment.
Suggested change
| Get the length of the string value stored at key. | |
| Get the length of the string value stored at `key`. |
| async def strlen(self, key: str) -> int: | ||
| """ | ||
| Get the length of the string value stored at key. | ||
| See https://redis.io/commands/strlen/ for details. |
There was a problem hiding this comment.
Suggested change
| See https://redis.io/commands/strlen/ for details. | |
| See https://redis.io/commands/strlen/ for more details. |
| See https://redis.io/commands/strlen/ for details. | ||
|
|
||
| Args: | ||
| key (str): The key |
There was a problem hiding this comment.
Suggested change
| key (str): The key | |
| key (str): The key to return its length. |
ikolomi
requested changes
Apr 7, 2024
There was a problem hiding this comment.
Please fix @shohamazon comments and consider changing the test not to test for the exact error message per @Yury-Fridlyand
GilboaAWS
force-pushed
the
main
branch
2 times, most recently
from
5da2582
to
1090bf7
Compare
shohamazon
approved these changes
Apr 7, 2024
shohamazon
reviewed
Apr 7, 2024
GilboaAWS
changed the title
shohamazon
changed the title
ikolomi
approved these changes
Apr 7, 2024
shohamazon
pushed a commit
to adanWattad/glide-for-redis
that referenced
this pull request
Apr 9, 2024
* Python: adds STRLEN command --------- Co-authored-by: Shoham Elias
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Python: adds STRLEN command --------- Co-authored-by: Shoham Elias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.