Python: adds GEODIST command #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
force-pushed
the
python/geodist
branch
2 times, most recently
from
8a97cbf
to
3888f2d
Compare
| @@ -221,7 +221,7 @@ pub(crate) fn expected_type_for_cmd(cmd: &Cmd) -> Option<ExpectedReturnType> { | |||
| b"HEXISTS" | b"HSETNX" | b"EXPIRE" | b"EXPIREAT" | b"PEXPIRE" | b"PEXPIREAT" | |||
| | b"SISMEMBER" | b"PERSIST" => Some(ExpectedReturnType::Boolean), | |||
| b"SMEMBERS" => Some(ExpectedReturnType::Set), | |||
| b"ZSCORE" => Some(ExpectedReturnType::DoubleOrNull), | |||
| b"ZSCORE" | b"GEODIST" => Some(ExpectedReturnType::DoubleOrNull), | |||
There was a problem hiding this comment.
Do you want to add a test?
|
|
||
| Returns: | ||
| Optional[float]: The distance between `member` and `member2`. | ||
| If one or both members do not exist, or if the key does not exist, returns None. |
There was a problem hiding this comment.
Suggested change
| If one or both members do not exist, or if the key does not exist, returns None. | |
| If one or both members do not exist, or if the key does not exist, returns `None`. |
Comment on lines
1517
to
1518
| >>> await client.geoadd("my_geo_set", {"Palermo": Coordinate(13.361389, 38.115556), "Catania": Coordinate(15.087269, 37.502669)}) | ||
| 2 # Indicates that two elements have been added to the sorted set "my_geo_set". |
There was a problem hiding this comment.
I think you can omit geoadd here
|
|
||
| Returns: | ||
| Optional[float]: The distance between `member` and `member2`. | ||
| If one or both members do not exist, or if the key does not exist, returns None. |
There was a problem hiding this comment.
Suggested change
| If one or both members do not exist, or if the key does not exist, returns None. | |
| If one or both members do not exist, or if the key does not exist, returns `None`. |
GilboaAWS
reviewed
Apr 11, 2024
| Adds geospatial members with their positions to the specified sorted set stored at `key`. | ||
| If a member is already a part of the sorted set, its position is updated. | ||
|
|
||
| See https://redis.io/commands/geoadd for more details. |
There was a problem hiding this comment.
Suggested change
| See https://redis.io/commands/geoadd for more details. | |
| See https://valkey-io.github.io/commands/geoadd for more details. |
| """ | ||
| Returns the distance between two members in the geospatial index stored at `key`. | ||
|
|
||
| See https://redis.io/commands/geodist for more details. |
There was a problem hiding this comment.
Suggested change
| See https://redis.io/commands/geodist for more details. | |
| See https://valkey-io.github.io/commands/geodist for more details. |
| """ | ||
| Returns the distance between two members in the geospatial index stored at `key`. | ||
|
|
||
| See https://redis.io/commands/geodist for more details. |
There was a problem hiding this comment.
Suggested change
| See https://redis.io/commands/geodist for more details. | |
| See https://valkey-io.github.io/commands/geodist for more details. |
shohamazon
force-pushed
the
python/geodist
branch
2 times, most recently
from
0bb6532
to
036f175
Compare
ikolomi
requested changes
Apr 18, 2024
shohamazon
force-pushed
the
python/geodist
branch
from
036f175
to
38c4d37
Compare
| == None | ||
| ) | ||
|
|
||
| assert await redis_client.set(key2, "value") == OK |
There was a problem hiding this comment.
add a comment for that test
ikolomi
approved these changes
Apr 22, 2024
shohamazon
force-pushed
the
python/geodist
branch
from
b784b3a
to
d4a2f7e
Compare
shohamazon
force-pushed
the
python/geodist
branch
from
d4a2f7e
to
cfb377e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ikolomi
approved these changes
Apr 24, 2024
ikolomi
requested changes
Apr 24, 2024
Co-authored-by: Yury-Fridlyand <[email protected]>
ikolomi
approved these changes
Apr 24, 2024
shohamazon
force-pushed
the
python/geodist
branch
from
0c47860
to
9c6d59c
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.