Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Added ZINTERSTORE and ZUNIONSTORE commands #1388

Merged
merged 14 commits into from
May 16, 2024
Merged

Python: Added ZINTERSTORE and ZUNIONSTORE commands #1388

merged 14 commits into from
May 16, 2024

Conversation

GilboaAWS
Copy link
Collaborator

No description provided.

@GilboaAWS GilboaAWS requested a review from a team as a code owner May 7, 2024 14:09
@GilboaAWS GilboaAWS added the python Python wrapper label May 7, 2024
@GilboaAWS GilboaAWS changed the title Added ZINTERSTORE and ZUNIONSTORE commands to python Python: Added ZINTERSTORE and ZUNIONSTORE commands May 7, 2024
@GilboaAWS GilboaAWS force-pushed the python_zinterstore branch 2 times, most recently from d7d036d to 32c5f91 Compare May 7, 2024 15:23
Yury-Fridlyand
Yury-Fridlyand reviewed May 7, 2024
View reviewed changes
python/python/glide/async_commands/core.py Show resolved Hide resolved
python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/transaction.py Outdated Show resolved Hide resolved
python/python/tests/test_async_client.py Show resolved Hide resolved
shohamazon
shohamazon reviewed May 8, 2024
View reviewed changes
python/python/glide/async_commands/core.py Outdated
Comment on lines 2734 to 2735
When in cluster mode, `destination` and all `keys` must map to the same `hash slot`.
see https://redis.io/commands/zinterstore/ for more details.
Copy link
Collaborator

@shohamazon shohamazon May 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When in cluster mode, `destination` and all `keys` must map to the same `hash slot`.
see https://redis.io/commands/zinterstore/ for more details.
When in cluster mode, `destination` and all `keys` must map to the same hash slot.
see https://valkey.io/commands/zinterstore/ for more details.

GilboaAWS and others added 8 commits May 15, 2024 09:47
@GilboaAWS @shohamazon
Update python/python/glide/async_commands/core.py
324424c 
Co-authored-by: Shoham Elias <[email protected]>
@GilboaAWS @Yury-Fridlyand
Update python/python/glide/async_commands/core.py
1e83e60 
Co-authored-by: Yury-Fridlyand <[email protected]>
@GilboaAWS @shohamazon
Apply suggestions from code review
026fad4 
Co-authored-by: Shoham Elias <[email protected]>
@GilboaAWS @shohamazon
Apply suggestions from code review
7cd9d6e 
Co-authored-by: Shoham Elias <[email protected]>
@GilboaAWS @shohamazon
Update python/python/glide/async_commands/core.py
b91fc5c 
Co-authored-by: Shoham Elias <[email protected]>
@GilboaAWS
Update python/python/glide/async_commands/transaction.py
a83ca16
@GilboaAWS @shohamazon
Apply suggestions from code review
1538815 
Co-authored-by: Shoham Elias <[email protected]>
@GilboaAWS @shohamazon
Update python/python/glide/async_commands/sorted_set.py
bc5a926 
Co-authored-by: Shoham Elias <[email protected]>
@GilboaAWS GilboaAWS merged commit 0d674ba into valkey-io:main May 16, 2024
6 checks passed
@GilboaAWS GilboaAWS deleted the python_zinterstore branch May 16, 2024 07:19
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
@GilboaAWS @cyip10
Python: Added ZINTERSTORE and ZUNIONSTORE commands (valkey-io#1388)
755d4e9 
Added ZINTERSTORE and ZUNIONSTORE commands to python

Co-authored-by: Shoham Elias 
Co-authored-by: Yury-Fridlyand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shohamazon shohamazon shohamazon approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@GumpacG GumpacG Awaiting requested review from GumpacG

@aaron-congo aaron-congo Awaiting requested review from aaron-congo

@jonathanl-bq jonathanl-bq Awaiting requested review from jonathanl-bq

@barshaul barshaul Awaiting requested review from barshaul

@acarbonetto acarbonetto Awaiting requested review from acarbonetto

@tjzhang-BQ tjzhang-BQ Awaiting requested review from tjzhang-BQ

Assignees
No one assigned
Labels
python Python wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GilboaAWS @Yury-Fridlyand @shohamazon